Collect environment by Xcaciv · Pull Request #94 · Xcaciv/Xcaciv.Command

Xcaciv · 2026-02-16T21:14:41Z

No description provided.

- Refactored IControllerEnvironmentContext.GetEnvironment to support a prefix option and updated all usages. - ControllerEnvironmentContext now always stores all variables in the command-specific environment and supports prefixing on retrieval. - CommandController updated to distinguish between global and command-specific environment updates. - Added CommandRegistryGetEnvironmentTests for comprehensive coverage of environment collection logic. - Introduced TestCommandsWithEnvironment.cs with diverse ICommandDelegate test implementations. - Updated all affected unit tests to match new environment logic and method signatures. - Enhanced EchoCommandDelegate and TestCommandDelegate to support default environment variables.

Copilot

Pull request overview

Adds a way to build a composite controller environment by instantiating registered commands and collecting their GetDefaultEnvironment() values, alongside updates to environment prefixing/merging behavior and associated tests.

Changes:

Added ICommandRegistry.GetEnvironment(ICommandFactory) + CommandController.GetEnvironment() to collect default env from registered commands.
Updated IControllerEnvironmentContext.GetEnvironment(...) to support optional key prefixing and adjusted controller/environment merge logic accordingly.
Added/updated tests and test command implementations to exercise environment collection and prefixing.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/tests/Xcaciv.Command.Tests/TestImplementations/TestCommandsWithEnvironment.cs	Adds many `ICommandDelegate` test commands with representative default environment dictionaries.
src/tests/Xcaciv.Command.Tests/TestImpementations/TestCommandDelegate.cs	Extends test delegates to support injectable default environments.
src/tests/Xcaciv.Command.Tests/ControllerEnvironmentContextTests.cs	Updates expectations/calls for new `GetEnvironment(commandName, prefix)` behavior and revised update semantics.
src/tests/Xcaciv.Command.Tests/Commands/RegifCommandTests.cs	Fixes indentation/formatting in a test method signature.
src/tests/Xcaciv.Command.Tests/CommandRegistryGetEnvironmentTests.cs	New tests validating registry-driven default environment collection.
src/tests/Xcaciv.Command.FileLoader.Tests/EnvironmentFileManagerTests.cs	Updates mock `IControllerEnvironmentContext` signature to match interface change.
src/Xcaciv.Command/Xcaciv.Command.csproj	Version bump to 3.3.3.
src/Xcaciv.Command/PipelineExecutor.cs	Removes an extra blank line (formatting).
src/Xcaciv.Command/ControllerEnvironmentContext.cs	Adds `prefix` option to command env retrieval and changes how per-command updates are stored.
src/Xcaciv.Command/CommandRegistry.cs	Implements environment collection by creating commands and aggregating defaults.
src/Xcaciv.Command/CommandController.cs	Adjusts parent environment reintegration rules and adds `GetEnvironment()` API.
src/Xcaciv.Command.Interface/Xcaciv.Command.Interface.csproj	Version bump to 3.3.3.
src/Xcaciv.Command.Interface/IControllerEnvironmentContext.cs	Changes `GetEnvironment(commandName)` signature to include optional `prefix`.
src/Xcaciv.Command.Interface/ICommandRegistry.cs	Adds `GetEnvironment(ICommandFactory)` to the public interface.
src/Xcaciv.Command.Interface/ICommandController.cs	Adds `GetEnvironment()` to the public interface.
src/Xcaciv.Command.FileLoader/Xcaciv.Command.FileLoader.csproj	Version bump to 3.3.3.
src/Xcaciv.Command.DependencyInjection/Xcaciv.Command.DependencyInjection.csproj	Version bump to 3.3.3.
src/Xcaciv.Command.Core/Xcaciv.Command.Core.csproj	Version bump to 3.3.3.
src/Directory.Packages.props	Updates referenced package versions to 3.3.3.

Copilot · 2026-02-16T21:23:32Z

src/Xcaciv.Command/CommandRegistry.cs

+    private static void ApplyDefaultEnvironment(IControllerEnvironmentContext controllerEnvironment, ICommandDescription commandDescription, ICommandFactory commandFactory, int depth = 0)
+    {
+        depth++;
+
+        if (!string.IsNullOrWhiteSpace(commandDescription.FullTypeName))
+        {
+            AddCommandDefaults(controllerEnvironment, commandDescription, commandFactory);
+        }
+
+        if (commandDescription.SubCommands.Count == 0)
+        {
+            return;
+        }
+
+        if (depth > 1) return;
+        foreach (var subCommand in commandDescription.SubCommands.Values)
+        {
+            AddCommandDefaults(controllerEnvironment, subCommand, commandFactory);
+        }
+    }


ApplyDefaultEnvironment increments a depth parameter and then immediately blocks traversal when depth > 1, but the method never recurses (it only iterates direct SubCommands). This makes the depth logic misleading/dead code; either remove it or implement true recursive traversal if deeper nesting is expected.

src/Directory.Packages.props

Copilot · 2026-02-16T21:23:32Z

src/Xcaciv.Command/ControllerEnvironmentContext.cs

+                    if (!prefix) return commandEnv.ToDictionary();
+                    // Add command prefix to keys when retrieving
+                    var commandPrefix = string.Concat(commandName, "_");
+                    var result = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
+                    foreach (var (key, value) in commandEnv)
+                    {
+                        var prefixedKey = key.StartsWith(commandPrefix, StringComparison.OrdinalIgnoreCase) ? key : commandPrefix + key;
+                        result[prefixedKey] = value;
+                    }
+                    return result;
+                }
+                return new Dictionary<string, string>();


GetEnvironment(commandName, prefix: false) returns commandEnv.ToDictionary(), which creates a case-sensitive dictionary. This breaks the environment context’s case-insensitive contract and can cause lookups to behave differently depending on the prefix flag. Return a Dictionary<string,string> using StringComparer.OrdinalIgnoreCase (and do the same for the empty/not-found return path).

Suggested change

if (!prefix) return commandEnv.ToDictionary();

// Add command prefix to keys when retrieving

var commandPrefix = string.Concat(commandName, "_");

var result = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);

foreach (var (key, value) in commandEnv)

{

var prefixedKey = key.StartsWith(commandPrefix, StringComparison.OrdinalIgnoreCase) ? key : commandPrefix + key;

result[prefixedKey] = value;

}

return result;

}

return new Dictionary<string, string>();

if (!prefix)

{

var result = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);

foreach (var environmentEntry in commandEnv)

{

result[environmentEntry.Key] = environmentEntry.Value;

}

return result;

}

// Add command prefix to keys when retrieving

var commandPrefix = string.Concat(commandName, "_");

var resultWithPrefix = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);

foreach (var (key, value) in commandEnv)

{

var prefixedKey = key.StartsWith(commandPrefix, StringComparison.OrdinalIgnoreCase) ? key : commandPrefix + key;

resultWithPrefix[prefixedKey] = value;

}

return resultWithPrefix;

}

return new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);

Copilot · 2026-02-16T21:23:33Z

src/Xcaciv.Command/ControllerEnvironmentContext.cs

@@ -232,39 +243,20 @@ public void UpdateEnvironment(Dictionary<string, string> dictionary, string comm
                return;
            }



The XML remarks for UpdateEnvironment(Dictionary<string,string>, string commandName) still describe splitting updates into command-specific (prefixed) vs shared/global, but the implementation now stores all keys in the command-specific dictionary and never updates _environment. Please update the documentation to match the new behavior, or restore the prior behavior if shared/global updates are still intended.

src/Xcaciv.Command/ControllerEnvironmentContext.cs

src/Xcaciv.Command/CommandController.cs

src/Xcaciv.Command/CommandRegistry.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…tation

Improved environment update logic to distinguish between global and command-specific variables. Now, command-prefixed variables are filtered out before global updates, and command-specific updates strip the prefix before storage. This prevents accidental overwrites and ensures clear separation between global and command environments.

Revised unit tests for ControllerEnvironmentContext to match updated environment variable key conventions: command-specific keys now omit redundant prefixes, while shared keys are prefixed with the command name. Adjusted test assertions and descriptions accordingly.

Xcaciv added 4 commits February 16, 2026 08:36

Add GetEnvironment to ICommandController and implement

1c9363c

Move environment aggregation to CommandRegistry

742f554

bump to version 3.3.3

709e8c4

Copilot AI review requested due to automatic review settings February 16, 2026 21:14

Copilot started reviewing on behalf of Xcaciv February 16, 2026 21:15 View session

bumping version

c3a8c03

Copilot AI reviewed Feb 16, 2026

View reviewed changes

Xcaciv and others added 6 commits February 17, 2026 16:34

Update src/Xcaciv.Command/CommandRegistry.cs

331051f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

remove unused counter

649b880

fixing dictionary key type and fixing comment to reflect new implemen…

d7a3a56

…tation

removing unused var

4ce1f53

Xcaciv merged commit 1ab563a into main Feb 18, 2026
2 checks passed

Xcaciv deleted the collect_environment branch February 18, 2026 15:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Collect environment#94

Collect environment#94
Xcaciv merged 11 commits intomainfrom
collect_environment

Xcaciv commented Feb 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -232,39 +243,20 @@ public void UpdateEnvironment(Dictionary<string, string> dictionary, string comm
		return;
		}

Conversation

Xcaciv commented Feb 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants